-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing flash message when adding first Container Provider #5832
Fix missing flash message when adding first Container Provider #5832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@miq-bot assign @mzazrivec |
I'm a bit puzzled here. Why does the after screen still show the landing / empty state page? Shouldn't it show the grid / list / tile with that one provider that's just been added? |
@mzazrivec maybe the page is rendered before the provider is actually added? Anyway, it's a bug... |
Perhaps this is the fix for the issue described? diff --git a/app/views/ems_container/show_list.html.haml b/app/views/ems_container/show_list.html.haml
index f4b32d02e..9a43c190d 100644
--- a/app/views/ems_container/show_list.html.haml
+++ b/app/views/ems_container/show_list.html.haml
@@ -1,5 +1,5 @@
#main_div
- - if Container.any?
+ - if ManageIQ::Providers::ContainerManager.any?
= render :partial => 'layouts/gtl'
- else
= render :partial => 'layouts/empty',
Since the |
Checked commits ZitaNemeckova/manageiq-ui-classic@046fa63~...b99388e with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
@mzazrivec Thanks :) Adding fixed as you suggested. Keeping my fix for cancel/error scenario. |
@romanblanco Are you OK with the current change? |
@mzazrivec OK 👍, thanks! |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1713504
Introduced by #5434
Go to Compute -> Containers-> Providers -> make sure you have no provider! -> add a new provider (see Bz for details) -> wait to be redirected back -> see there's no success/error message

Before:
After:

Go to Compute -> Containers-> Providers -> make sure you have no provider! -> Configuration -> Add a new Container Provider -> cancel -> see there's no "Canceled by user" message
Fixed for all providers.
Before:

After:

@miq-bot add_label hammer/no, bug
cc: @romanblanco