Fixed Error in Restore Cloud Volume Backup #5830
Conversation
|
Checked commit Hchrast@6bc52e5 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@aufi please have a look. It fixes https://bugzilla.redhat.com/show_bug.cgi?id=1729981 :) |
|
@aufi ping? Do we have your approval here? Thanks. |
|
@miq-bot add_label ivanchuk/yes |
| @@ -27,7 +27,7 @@ def volume_select | |||
|
|
|||
| def volume_form_choices | |||
| assert_privileges("cloud_volume_backup_restore_to_volume") | |||
| volume_choices = ManageIQ::Providers::CloudManager::CloudVolume.all | |||
| volume_choices = CloudVolume.all | |||
There was a problem hiding this comment.
I believe there are rules for where the backup can be restored. At least you will need to filter by the same EMS as backup. Maybe even the same tenant? @aufi can you advise?
There was a problem hiding this comment.
Sounds it didn't work according to those rules before. Well if anyone knows those rules @Hchrast can add them:)
There was a problem hiding this comment.
As @ZitaNemeckova says, this works as before, so the PR looks good to me, since it's fixing a bug 👍
@aufi we should have another PR, moving the list to model. Then we can define in OpenStack provider what is the right query.
|
@miq-bot add_label blocker |
Fixed Error in Restore Cloud Volume Backup (cherry picked from commit 7a96e01) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1729981
|
Ivanchuk backport details: |
Go to: Storage -> Block Storage -> Volume Backups -> Select one -> Configuration -> Restore Backup to Cloud Volume
Before:
After:
@miq-bot add_label bug
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1729981