Fix Policy breadcrumbs when coming from GTL page

[ZitaNemeckova]

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1720714

How to reproduce:
Go Compute -> Infrastructure -> VMs -> check two or more VMs -> Policy -> Edit Tags/Policy Simulation/Manage Policies -> see breadcrumbs

Before:

After:

There's no change when doing the same from a VM Summary page.

Following guides for breadcrumbs Tagging/Ownership/etc.

@miq-bot add_label bug, hammer/no

@rvsia please have a look, thanks :)

[rvsia]

@ZitaNemeckova

I think you can solve this issue by checking if variable in the special_breadcrumb method has length == 1, if bigger then return nil. This check was there.. however it has gone missing probably during some refactoring... 😰

[ZitaNemeckova]

@rvsia well, there still would be a VM name in case you check just one VM in GTL page. I think we don't want a VM name when coming from GTL page.

[rvsia]

@ZitaNemeckova When I designed the breadcrumbs I was following this rule: show the Item's breadcrumb on tag page (etc.) if there is only one item which is being tagged. https://github.com/ManageIQ/manageiq-ui-classic/wiki/Breadcrumbs

[rvsia]

The condition can be moved to line 70:

return unless variable && variable.count == 1 or
return if !variable || variable.count != 1

[ZitaNemeckova]

Fixed. Chose the second option to get rid of unless 😃

[rvsia]

Great! Thanks! 🏆

[miq-bot]

Checked commits ZitaNemeckova/manageiq-ui-classic@bd815c1~...28b67ec with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

[simaishi]

Ivanchuk backport details:

$ git log -1
commit 83a5289945bc0a51b34c0b6fdb21dbf278c9d4b0
Author: Martin Povolny <[email protected]>
Date:   Fri Jul 26 09:34:38 2019 +0200

    Merge pull request #5814 from ZitaNemeckova/fix_policy_bc
    
    Fix Policy breadcrumbs when coming from GTL page
    
    (cherry picked from commit 5e2db323ebed5eb888ec947cc4f6f3ff41458f9c)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1720714