[HAMMER] Rescue the right kind of error from the dialog field circular reference checker #5762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
force-pushed
the
fix_specs_for_18890
branch
from
855229a to
fa06d59
Compare
d-m-u
changed the title
|
@eclarizio any chance you want to review, please? it's needed soon... |
h-kataria
approved these changes
Jul 1, 2019
simaishi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dialog field circular reference checker got refactored (ManageIQ/manageiq#18890) and backported to hammer and this fixes the specs broken by that and changes the error inheritance to be correct.
Related master PR: #5755
@miq-bot assign @simaishi