Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Networks Load Balancer menu #5754

Merged
merged 3 commits into from
Jul 5, 2019
Merged

Remove deprecated Networks Load Balancer menu #5754

merged 3 commits into from
Jul 5, 2019

Conversation

GregP
Copy link
Contributor

@GregP GregP commented Jun 27, 2019

Remove deprecated Networks Load Balancers menu and supporting code.

Part 2 of code fix. Part 1 is found here: ManageIQ/manageiq#18918

https://bugzilla.redhat.com/show_bug.cgi?id=1672949

Screen shot prior to code fix:
Networks main menu prior to code fix

Screen shot post code fix:
Networks main menu post code fix

@GregP GregP requested a review from martinpovolny as a code owner June 27, 2019 16:03
@GregP GregP changed the title Remove deprecated Networks Load Balancer menu [WIP] Remove deprecated Networks Load Balancer menu Jun 27, 2019
@mzazrivec mzazrivec added the wip label Jun 28, 2019
@GregP GregP force-pushed the remove_load_balancer_menu branch from 1890815 to 1f71a8a Compare June 28, 2019 19:24
@GregP GregP force-pushed the remove_load_balancer_menu branch from 1f71a8a to 7e09288 Compare June 28, 2019 20:32
@h-kataria
Copy link
Contributor

@GregP i still see
https://github.com/ManageIQ/manageiq-ui-classic/blob/937a12b735fa64940c5b8d04a3800dd5bf8ec0ac/app/helpers/load_balancer_helper/textual_summary.rb
https://github.com/ManageIQ/manageiq-ui-classic/blob/937a12b735fa64940c5b8d04a3800dd5bf8ec0ac/app/helpers/application_helper/toolbar/load_balancer_center.rb
https://github.com/ManageIQ/manageiq-ui-classic/blob/937a12b735fa64940c5b8d04a3800dd5bf8ec0ac/app/helpers/application_helper/toolbar/load_balancers_center.rb

@GregP GregP force-pushed the remove_load_balancer_menu branch from 2eb4d0f to a85334f Compare July 2, 2019 04:21
@GregP GregP changed the title [WIP] Remove deprecated Networks Load Balancer menu Remove deprecated Networks Load Balancer menu Jul 2, 2019
@miq-bot miq-bot removed the wip label Jul 2, 2019
@miq-bot
Copy link
Member

miq-bot commented Jul 2, 2019

Checked commits GregP/manageiq-ui-classic@e722a2d~...a85334f with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
7 files checked, 2 offenses detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - error parsing JSON result

spec/controllers/ems_network_controller_spec.rb

@GregP
Copy link
Contributor Author

GregP commented Jul 3, 2019

@h-kataria Ready for review.

@h-kataria h-kataria self-assigned this Jul 5, 2019
@h-kataria
Copy link
Contributor

looks good

@h-kataria h-kataria added this to the Sprint 115 Ending Jul 8, 2019 milestone Jul 5, 2019
@h-kataria h-kataria merged commit 79e4310 into ManageIQ:master Jul 5, 2019
@agrare agrare mentioned this pull request Mar 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpovolny martinpovolny Awaiting requested review from martinpovolny

Assignees

@h-kataria h-kataria

Labels
changelog/yes enhancement hammer/no networks technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GregP @h-kataria @miq-bot @mzazrivec