Do not let angular parse the treeview data as it can be 🐢 HUGE 🐌 #5729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
changed the title
himdel
reviewed
Jun 20, 2019
| @@ -1,10 +1,12 @@ | |||
| - return if @display == 'generic_objects' || @display == 'main' | |||
| = miq_accordion_panel(_("Generic Object Classes"), true, "god") do | |||
| :javascript | |||
| ManageIQ.tree.data['#{tree.name}'] = #{tree.locals_for_render[:bs_tree]}; | |||
There was a problem hiding this comment.
Ugh, GOD is special, there's no tree, only @tree.
(and that's the only issue I'm seeing 👍)
There was a problem hiding this comment.
Oh GOD WHYYY 😢 I'll fix it
skateman
force-pushed
the
explorer-tree-init-object
branch
from
2ba59f4 to
02a4883
Compare
|
Checked commit skateman@02a4883 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Tested both in GO and in other explorers, LGTM :) |
simaishi
pushed a commit
that referenced
this pull request
Jul 22, 2019
Do not let angular parse the treeview data as it can be 🐢 HUGE 🐌 (cherry picked from commit 6d088fe) https://bugzilla.redhat.com/show_bug.cgi?id=1727443
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some profiling around the TreeView with 5 thousand nodes and I realized that the bottleneck is in Angular and not the TreeView code. I asked @himdel about the problem and we realized that this was caused by a bugfix that started sending the tree data as an object instead of a string. The object is being parsed by angular and if it is 5MB, well 🐢 🐌 happens.
The solution is to get the data into the component in an alternative way, so preventing Angular from unnecessarily parsing it. Ideally this could be solved by having separate (UI-)API endpoints for trees, but we're not there yet. So our solution was to utilize the
ManageIQ.treesglobal object by temporarily saving the data into it until the component gets a reference.After this change the performance increase is significant, the bottleneck now is in the rendering which is totally fine. We can't really make the browser faster 😉
Before:
After:
@miq-bot add_reviewer @martinpovolny
@miq-bot add_reviewer @himdel
@miq-bot add_label performance, bug, trees, hammer/yes
https://bugzilla.redhat.com/show_bug.cgi?id=1703556