Display container Map Tag delete confirmation message #5727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit GregP@ef3e8db with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@h-kataria Ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes display of delete Map Tag delete action confirmation messages when successful. Also, changes wording on the Add Map tag page to say "Enter category for text box (as opposed to prior "Choose..." implying more than one selection.
https://bugzilla.redhat.com/show_bug.cgi?id=1707328
Screen shot of Add Map Tag page with "Choose..." wording prior to code fix:
No "delete successful" confirmation message displayed prior to code fix, notice message from prior action of Add still displayed:
Add new Map Tag page post code fix with "Enter..." for category text box:
Delete Map Tag confirmation message displayed post code fix:
