-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Price to Catalog Items. #5719
Merged
himdel
merged 9 commits into
ManageIQ:master
from
h-kataria:add_pricing_to_service_catalog
Jul 4, 2019
+197
−4
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9ad9add
Added Price to Catalog Items.
h-kataria 1bc6b55
Addressed PR feedback
h-kataria 7fe11f4
Changed label `Rate` to `Price`
h-kataria 64ac3cb
Added missing changes to save price for catalog bundle
h-kataria fcb613c
Changed labels to `Price / Month`
h-kataria 11a9375
Added validation on "Price" field
h-kataria acbccef
Some more fixes to price validation
h-kataria 3703088
Addressed rubocop warnings
h-kataria 12a460a
Empty out Price value during save is currency was unset.
h-kataria File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added missing changes to save price for catalog bundle
Also made changes to show `Price` as required field if user has made selection in a currency drop down. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1602072
- quinteros-2.2
- quinteros-2.1
- quinteros-2
- quinteros-1
- petrosian-1
- oparin-1.1
- oparin-1
- najdorf-1.3
- najdorf-1.2
- najdorf-1.1
- najdorf-1
- morphy-1
- morphy-1-beta1
- lasker-1
- lasker-1-beta1
- kasparov-2
- kasparov-1
- kasparov-1-beta1.1
- kasparov-1-beta1
- kasparov-1-alpha1
- jansa-4
- jansa-3
- jansa-2
- jansa-1
- jansa-1-rc2
- jansa-1-rc1
- jansa-1-beta1
- jansa-1-alpha1
- ivanchuk-8
- ivanchuk-7
- ivanchuk-6
- ivanchuk-5
- ivanchuk-4
- ivanchuk-3
- ivanchuk-2
- ivanchuk-1
- ivanchuk-1-rc1
- ivanchuk-1-beta2
- ivanchuk-1-beta1
commit 64ac3cb3e3da7b113c81d4d2bda8faa01f26cd1f
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (name == 'currency' && ! value)
should fix the problem when unsetting currency. (It goes from undefined to a currency, but then it goes to null, not undefined, when unselecting.)