Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use API call to populate cloud_types drop down #570

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Use API call to populate cloud_types drop down #570

merged 1 commit into from
Mar 17, 2017

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented Mar 3, 2017 •
edited
Loading

@h-kataria h-kataria changed the title Use API call to populate cloud_types drop down [WIP] Use API call to populate cloud_types drop down Mar 3, 2017
@h-kataria
Copy link
Contributor Author

@gmcculloug this PR depends on ManageIQ/manageiq#13951

@miq-bot
Copy link
Member

miq-bot commented Mar 6, 2017

This pull request is not mergeable. Please rebase and repush.

@h-kataria h-kataria force-pushed the api_call_for_cloud_types branch 2 times, most recently from 0d78fb8 to 6a72c2f Compare March 13, 2017 15:34
@h-kataria h-kataria force-pushed the api_call_for_cloud_types branch 2 times, most recently from 238ed45 to 4e78b47 Compare March 15, 2017 18:03
@h-kataria h-kataria changed the title [WIP] Use API call to populate cloud_types drop down Use API call to populate cloud_types drop down Mar 15, 2017
@h-kataria h-kataria removed the wip label Mar 15, 2017
@h-kataria h-kataria force-pushed the api_call_for_cloud_types branch from 4e78b47 to 895e10c Compare March 15, 2017 19:01
@h-kataria
Copy link
Contributor Author

@gmcculloug @dclarizio dependent core repo PR has been merged

@dclarizio dclarizio self-assigned this Mar 16, 2017
@gmcculloug
Copy link
Member

@h-kataria From the attached screenshot it looks like you are returning all types. The list for cloud should not include Machine or Scm credential types. It should contain credential type with the exclusion of Machine, Scm and Network

cc @bdunne @bzwei

@h-kataria
Copy link
Contributor Author

@gmcculloug I am not sure how can i exclude those types, @jntullo can you please look into this and only return cloud types.

@jntullo
Copy link

jntullo commented Mar 17, 2017

@h-kataria if you look here, we've added in a type so that you can know whether it is a cloud type or not

@h-kataria h-kataria force-pushed the api_call_for_cloud_types branch from 895e10c to 1d521eb Compare March 17, 2017 13:20
@h-kataria
Use API call to populate cloud_types drop down
0c93aa9 
Use credential_types from options returned from API call to populate Cloud Types drop down. Added changes to handle sorting of list of cloud types returned from API call

https://www.pivotaltracker.com/story/show/140931909
@h-kataria h-kataria force-pushed the api_call_for_cloud_types branch from 1d521eb to 0c93aa9 Compare March 17, 2017 13:22
@miq-bot
Copy link
Member

miq-bot commented Mar 17, 2017

Checked commit h-kataria@0c93aa9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 👍

@gmcculloug
Copy link
Member

@h-kataria Since we are currently limiting to Amazon and VMware credentials this looks good. 👍

@dclarizio Please review.

@dclarizio dclarizio merged commit 7fc03b1 into ManageIQ:master Mar 17, 2017
@dclarizio dclarizio added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 17, 2017
@h-kataria h-kataria deleted the api_call_for_cloud_types branch March 21, 2017 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
enhancement services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@h-kataria @miq-bot @gmcculloug @jntullo @dclarizio