-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening URLs through automate #5688
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpovolny
force-pushed
the
automate_open_url
branch
from
June 11, 2019 13:31
4a584b6
to
c349fa1
Compare
martinpovolny
force-pushed
the
automate_open_url
branch
from
June 30, 2019 09:02
8771432
to
fbf08f6
Compare
This was referenced Jul 1, 2019
martinpovolny
force-pushed
the
automate_open_url
branch
3 times, most recently
from
July 15, 2019 21:35
83a8a3d
to
4d552fa
Compare
martinpovolny
changed the title
[WIP] Opening URLs through automate
Opening URLs through automate
Jul 16, 2019
Fixing conflict, rebasing. |
martinpovolny
force-pushed
the
automate_open_url
branch
from
July 21, 2019 15:15
4d552fa
to
19c957e
Compare
martinpovolny
force-pushed
the
automate_open_url
branch
from
July 22, 2019 15:05
19c957e
to
02d2cf0
Compare
Checked commits martinpovolny/manageiq-ui-classic@b81428e~...27cb094 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
mzazrivec
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFE BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1550002
Requires:
Doc PR: ManageIQ/guides#355
TODO
pass the targetClass though the form,(needs to be checked)allow theOpenURL
checkbox when editing custom buttons for all relevant classes.update the documentation (from here: Fix open_url with dialog #4334) and put it to guidesTested automate code for User
(the
vmdb_object_type
would work for other entities as well, but the ID is stored elsewhere)Tested automate code for VM
A screenshot to help navigate in the UI
(it's best to follow the Guides article in the above PR)