Display the custom login logo on the about modal #5685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label hammer/yes |
skateman
force-pushed
the
about-modal-background
branch
from
c60dc90 to
37884f7
Compare
|
Checked commits skateman/manageiq-ui-classic@fe7a1e7~...37884f7 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jun 13, 2019
Display the custom login logo on the about modal (cherry picked from commit 1ce26ee) https://bugzilla.redhat.com/show_bug.cgi?id=1720242
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ugly hack that adds a class on each page's body element that will trigger the custom background image on the about modal. Eventually we would like to have a feature in PF for this.
@miq-bot add_label bug, graphics
@miq-bot add_reviewer @epwinchell
@miq-bot add_reviewer @himdel
https://bugzilla.redhat.com/show_bug.cgi?id=1717116