Convert Tenants details page to textual summary and add Relationships with Services, Automate Domain and Providers #5675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label changelog/yes, hammer/no |
hstastna
force-pushed
the
Tenant_summary_relationships
branch
8 times, most recently
from
3fac152 to
f83f71f
Compare
hstastna
changed the title
hstastna
force-pushed
the
Tenant_summary_relationships
branch
6 times, most recently
from
cd32f78 to
a123a4b
Compare
hstastna
force-pushed
the
Tenant_summary_relationships
branch
3 times, most recently
from
4a4eed6 to
fd7149a
Compare
hstastna
force-pushed
the
Tenant_summary_relationships
branch
7 times, most recently
from
96fd535 to
b62218a
Compare
Actually, probably the whole toolbar should be hidden. As the Configuration also has button only related to the Tenant. |
|
And what about Configuration button? I think that both buttons should be there or none of them. |
hstastna
force-pushed
the
Tenant_summary_relationships
branch
from
7fe755b to
708fba0
Compare
Yeah, none of them. |
hstastna
force-pushed
the
Tenant_summary_relationships
branch
3 times, most recently
from
f6ad2a2 to
415d7ca
Compare
Also set explorer to true for proper replacing right cell with GTL.
Display nested lists of Catalog Items/Bundles, Automate Domains, Providers. Providers and automate domans are not clickable.
Add also spec for updating view_options in nested_list in GenericShowMixin
Fix highlighting Group in accordion after clicking on it in Tenant's textual summary.
hstastna
force-pushed
the
Tenant_summary_relationships
branch
from
415d7ca to
0672cc8
Compare
hstastna
force-pushed
the
Tenant_summary_relationships
branch
2 times, most recently
from
97de4d2 to
32ef759
Compare
hstastna
force-pushed
the
Tenant_summary_relationships
branch
from
32ef759 to
b931d92
Compare
|
Checked commits hstastna/manageiq-ui-classic@88d7587~...b931d92 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
🎆 🍾 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFE: https://bugzilla.redhat.com/show_bug.cgi?id=1678124
Details about some changes: #6060
Tracking issue: ManageIQ/manageiq#18734
Depends on: (all merged)
ManageIQ/manageiq#18733
ManageIQ/manageiq#18735
ManageIQ/manageiq-automation_engine#318
ManageIQ/react-ui-components#129
ManageIQ/manageiq#19071
This PR includes converting Tenants details page to textual summary page. We need this to be able easily to add Relationships table with related Services, Automate Domain and Providers info. This PR also adds this.
Where:
Configuration ☸️ > Access Control accordion > Tenants
TODO:
convert an existing Tenants details page to textual summarymake Parent, Child Tenants, Groups under Properties clickable (if there are any)edit existingEdit TagGroup component to support onClick and displaying titles react-ui-components#129TagGroupcomponent to make items clickable:solve the background/lines of the items in the table - for Child Tenants, Groupsadd Relationships with related Service Catalog Items, Automate Domain and Providers info (number of items) and make them clickableadd yamls, list views for displaying Catalog Items and Bundles, Automate Domains, Providersdisplay GTL, with pagination, accordion (only list view is enough to be displayedfix breadcrumbsspecswhen clicking on some Group in textual summary of a Tenant, the Group should be highlighted in accordionNotes:
We can find Automate Domains under Automation -> Automate -> Explorer.
Making Automate Domains and Providers in nested lists clickable will be done via following up PR.
After:
Displaying also Child Tenants of an actual Tenant in Properties table (and no Groups present):
Displaying Catalog Items from Relationships table: