Add Copy option to Catalog Item/Bundle

[ZitaNemeckova]

Go to Services -> Catalogs -> Catalog Items -> select one -> Configuration -> Copy this Item

Backend PR(merged) ManageIQ/manageiq#18464 . Only valid and non-ServiceTemplateAnsiblePlaybook items can be copied.

Not all attributes are copied. Tracked in ManageIQ/manageiq#18949
It's not possible to copy a copy with custom buttons. Tracked in ManageIQ/manageiq#18954 => Fixed in ManageIQ/manageiq#18960

Toolbar:

Form:

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1678149

@miq-bot add_label wip

[ZitaNemeckova]

@miq-bot remove_label unmergeable
@miq-bot add_label enhancement, changelog/yes, hammer/no, react

[PanSpagetka]

You have prefilled name in the form like "Copy of X", but form in initial state can't be submitted (Add button is disabled).

[PanSpagetka]

This error message is little bit confusing. I needed to read it several times to understand it correctly.

[h-kataria]

@ZitaNemeckova maybe message should be "Selected Catalog Bundle or Ansible Playbook Items can not be copied."

[ZitaNemeckova]

I went with Selected item can not be copied. Because it's Ansible Playbook or not valid.

[ZitaNemeckova]

@miq-bot remove_label wip

[h-kataria]

@ZitaNemeckova it seems to be working pretty good. Minor issues noticed

• if i create a Catalog Item with a name "1" and then try to copy that with the same name i get a message on screen that "Name has already been taken" only if i shift my focus out of the text field, is that working as designed?
• Second issue is that if i try to copy item with a name "1 " it does not complain and lets me add an item with the specified name, should we strip trailing/leading blank spaces

[miq-bot]

Checked commits ZitaNemeckova/manageiq-ui-classic@97d6abf~...97e3000 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 1 offense detected

app/controllers/catalog_controller.rb

• ❗ - Line 1904, Col 61 - Style/MultipleComparison - Avoid comparing a variable with multiple items in a conditional, use Array#include? instead.

[ZitaNemeckova]

@h-kataria Fixed first point. About the second I still think that leaving trailing/leading blank spaces is ok. Fixing it would probably create more trouble.

[h-kataria]

@ZitaNemeckova @d-m-u found another issue, when copying a catalog item, it's additional Tenant information does not get copied.

[tinaafitz]

@d-m-u Can you add the additional tenant information @h-kataria mentioned above?

[h-kataria]

verified in UI. Looks good.