Drop patternfly 4 support again #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly reverts #5537, except I'm keeping the app/stylesheet/ because we're already using it.
…prematurely patternfly 4 will be supported in J-release, not I-release
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/6fbf5fd8b07c791ec76fe65840f8a933f9d37ed1~...2348c53c9262af5c49bf0daf40a9f348997f7ce5 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
When we introduce patternfly 4 again, consider wrapping in a .pf4 {
@import '~@patternfly/patternfly/patternfly.scss';
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decision is to support patternfly 4 only in J-release, not Ivanchuk.
(IE11 support is still going away in Ivanchuk.)
So, reverting #5537, except for introduction of
app/stylesheet/application-webpack.scss.And adding guards to prevent accidental requires of patternfly 4 styling from plugins or depedencies.
Cc @skateman @epwinchell @mturley