Datastore selection flash message fix #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@h-kataria Please review. |
h-kataria
reviewed
Mar 2, 2017
| @@ -32,7 +32,7 @@ def storage_list | |||
| def miq_search_node | |||
| options = {:model => "Storage"} | |||
| process_show_list(options) | |||
| @right_cell_text = _("All %{title} Datastores") % {:title => ui_lookup(:ui_title => "datastore")} | |||
| @right_cell_text = _("All Datastores") % {:title => ui_lookup(:ui_title => "datastore")} | |||
There was a problem hiding this comment.
@GregP remove setting of :title it is not being used.
the change should be
@right_cell_text = _("All Datastores")
or
@right_cell_text = _("All %{title}") % {:title => ui_lookup(:models => 'datastore'}
Corrected flash message text when selecting datastore filter for display https://bugzilla.redhat.com/show_bug.cgi?id=1398744
GregP
force-pushed
the
datastore_filter_display_msg
branch
from
5642947 to
7caa244
Compare
|
@h-kataria Please review. |
|
Checked commit GregP@7caa244 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
looks good |
|
Euwe backport (to manageiq repo) details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected flash message text when selecting datastore filter for display
https://bugzilla.redhat.com/show_bug.cgi?id=1398744
Screen shots before and after attached below:
Before:
After: