-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the replication exclude tables #5546
Conversation
c5ec229
to
7baac0a
Compare
With the new backend replication technology, making a new set of excluded tables take effect requires action on both the remote and global regions. Because of this the user experience would be much worse for a feature that is not really necessary.
7baac0a
to
7f0ffc7
Compare
Checked commit carbonin@7f0ffc7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
I'm thinking that whatever order we merge these two PRs in will likely break the UI specs... 😟 @martinpovolny wondering who would be able to review this one so that we can get it in rather quickly either just before or just after ManageIQ/manageiq#18686 is merged? |
@himdel Can you point out who should review this? Thanks! |
I guess that's me ;) already looking... |
This looks fine, the field was only available for remote, now it's gone, not seeing any remains of that, saving was updated... 👍 Tested in UI, the Also, one less codemirror to worry about 👍 :) (It looks like we could merge the UI part now without breaking anything, is that right?) (One thing I do notice, is that saving outputs a |
@miq-bot add_label changelog/yes |
Aand sounds like merging this one won't break anything after all, Merging now :) |
With the new backend replication technology, making a new set of
excluded tables take effect requires action on both the remote and
global regions. Because of this the user experience would be much
worse for a feature that is not really necessary.
Requires ManageIQ/manageiq#18686
@miq-bot add_label wip, hammer/no, pending core
Before:
After: