Unify sorting in GOD of Button Groups #5513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GOD tree sorts Button Groups by their name. Fixing table to have same sort as tree Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1665031
|
@ZitaNemeckova Cannot apply the following label because they are not recognized: automate/automation |
|
@miq-bot add_label automation/automate |
|
Checked commit ZitaNemeckova@578acdb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label changelog/yes |
|
@miq-bot remove_label bugzilla needed |
|
@romanblanco please have a look, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOD tree sorts Button Groups by their name. Fixing table to have same sort as tree.
Go to Automation -> Automate -> Generic Objects -> Add few Button Groups with names that go from Z to A (so their chronological and alphabetical orders are different!) -> see tree and table orders are different
Before:
After:
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1665031
#5146 didn't fix the problem completely.
@miq-bot add_label bug, generic objects, automate/automation, hammer/yes, gaprindashvili/yes, bugzilla needed