Use table name when generating SQL to filter jobs on ... Container Analysis Tasks
screens
#551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is preparation for ManageIQ/manageiq#14030
There is
Owner
column on Jobs screens and right now it takes value fromjobs.agent_name
which get populated frommiq_servers.name
.After linking
Job
andMiqServer
(PR ManageIQ/manageiq#14030) not usedjobs.agent_name
column will be removed and "Owner" column would get data directly frommiq_server.name
.SQL for filtering would join 2 tables. To avoid SQL error on the columns with the name, we need to add table name (the same what was done to
miq_tasks
SQL generation in #344 )in this PR:
jobs
when generating filtering SQL forJob
modeljobs
toThere are no changes on UI:
BEFORE:
![before](https://cloud.githubusercontent.com/assets/6556758/23510769/dac98750-ff28-11e6-9853-e9ce50072cd5.png)
AFTER:
![after](https://cloud.githubusercontent.com/assets/6556758/23510779/e26cdcbe-ff28-11e6-8772-8ef3a5b63cb8.png)
@miq-bot add-label enhancement
\cc @gtanzillo @dclarizio