Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use numeric comparison for IDs #5503

Merged
merged 2 commits into from
Apr 29, 2019

Conversation

bmclaughlin
Copy link
Contributor

Fixes a bug where Expression Editor was comparing integer fields with 'Contains' rather than using a numeric comparison.

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1698168

@miq-bot
Copy link
Member

miq-bot commented Apr 29, 2019

Checked commits bmclaughlin/manageiq-ui-classic@d377c3c~...4f7acd4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@h-kataria h-kataria self-assigned this Apr 29, 2019
@h-kataria h-kataria added this to the Sprint 110 Ending Apr 29, 2019 milestone Apr 29, 2019
@h-kataria h-kataria merged commit 85fa7e5 into ManageIQ:master Apr 29, 2019
@bmclaughlin bmclaughlin deleted the fix-expression-editor-error branch April 29, 2019 21:41
simaishi pushed a commit that referenced this pull request Apr 30, 2019
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 7c23944ee5c15e798704e3b1df41834af8d83601
Author: Harpreet Kataria <[email protected]>
Date:   Mon Apr 29 16:37:26 2019 -0400

    Merge pull request #5503 from bmclaughlin/fix-expression-editor-error
    
    Use numeric comparison for IDs
    
    (cherry picked from commit 85fa7e519dc313aa381fc09b4959c0024cc17f03)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1704771

@bmclaughlin
Copy link
Contributor Author

Before:
image

After:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants