Adding SSO to External Logging link #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzazrivec
suggested changes
Mar 4, 2017
| res = http.request(Net::HTTP::Get.new(url.request_uri)) | ||
| rescue Errno::ECONNREFUSED, SocketError => _e | ||
| javascript_flash(:text => _("Cannot access '#{url.hostname}'. " \ | ||
| "Make sure that the logging route is accessible"), |
There was a problem hiding this comment.
You cannot use #{} inside a gettext string. You need to change this to:
_("Cannot access '%{hostname}'. Make sure that the logging route is accessible") % {:hostname => url.hostname}
enoodle
force-pushed
the
common_logging_sso
branch
from
5956121 to
d9e8870
Compare
enoodle
changed the title
enoodle
force-pushed
the
common_logging_sso
branch
2 times, most recently
from
2ebe7a8 to
4e3f750
Compare
enoodle
changed the title
enoodle
force-pushed
the
common_logging_sso
branch
from
4e3f750 to
56be18b
Compare
enoodle
force-pushed
the
common_logging_sso
branch
from
56be18b to
74b1968
Compare
|
@mzazrivec I made the requested change, PTAL. |
enoodle
force-pushed
the
common_logging_sso
branch
from
74b1968 to
25082a8
Compare
|
Checked commit enoodle@25082a8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
mzazrivec
approved these changes
Mar 30, 2017
|
@miq-bot add_label fine/yes |
simaishi
pushed a commit
that referenced
this pull request
Apr 19, 2017
Adding SSO to External Logging link (cherry picked from commit 815b8e4) https://bugzilla.redhat.com/show_bug.cgi?id=1443714
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will attempt to use the /auth/sso-setup and /auth/sso-login endpoints that are available to the openshift-auth-proxy. In case of a failure this will fall back to the non sso behavior.
[1]fabric8io/openshift-auth-proxy#11