-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tenants tree to Catalog Item Edit page #5445
Add Tenants tree to Catalog Item Edit page #5445
Conversation
@miq-bot add_reviewer @ZitaNemeckova |
c990666
to
837fac6
Compare
745aa75
to
a54ea19
Compare
55749a1
to
e3f3760
Compare
62af2a3
to
c3daf1c
Compare
Also update failing specs for st_set_form_vars method in catalog controller spec. Update also specs for the two haml files, under spec/views/catalog. Add another specs for saving selected tenants to @edit and for build_tenants_tree method.
Add the component to init the tree for Ansible Playbook Catalog Item type.
Add support to catalogItemFormController, add new miqOnCheckTenantTree method, use sendDataWithRx and listenToRx to get appropriate data in appropriate ctrl. Also pass initial array of additional Tenants' ids to angular.
Make the button responsive in Ansible Playbook Catalog Item edit page.
906e4f0
to
ec0cf6e
Compare
Update the tests with additional tenants ids
ec0cf6e
to
53e3e2e
Compare
Checked commits hstastna/manageiq-ui-classic@1721ffa~...53e3e2e with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 **
|
@h-kataria @hstastna I tested creating and updating ansible playbook catalog and I am confirming that storing additional tenants work perfectly, If you want to test it also (It would be great) you can use this patch (not sure if it is best way but it is working locally) index 6748df8631..cb5e527e95 100644
--- a/app/models/service_template_ansible_playbook.rb
+++ b/app/models/service_template_ansible_playbook.rb
@@ -63,7 +63,7 @@ class ServiceTemplateAnsiblePlaybook < ServiceTemplateGeneric
def self.create_job_templates(service_name, description, config_info, auth_user, service_template = nil)
[:provision, :retirement, :reconfigure].each_with_object({}) do |action, hash|
next unless new_job_template_required?(config_info[action], action, service_template)
- hash[action] = { :configuration_template => create_job_template(build_name(service_name, action), description, config_info[action], auth_user) }
+ hash[action] = { :configuration_template => ManageIQ::Providers::AnsibleTower::AutomationManager::ConfigurationScript.create }
end
end
private_class_method :create_job_templates
@@ -216,7 +216,7 @@ class ServiceTemplateAnsiblePlaybook < ServiceTemplateGeneric
next unless job_template
if info.key?(:playbook_id)
_tower, params = self.class.send(:build_parameter_list, self.class.send(:build_name, name, action), description, info)
- job_template.update_in_provider_queue(params)
+ #job_template.update_in_provider_queue(params)
else
delete_job_templates([job_template], action)
end
(END)
|
Due to enhancement made in ManageIQ#5445 , Now list of tenant can be lot of tenant names and may not fit properly on the list view, so removing the column from list view as this information is available in a nice tree view on the details view of a Catalog Item. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1740172
Due to enhancement made in ManageIQ#5445 , Now list of tenant can be lot of tenant names and may not fit properly on the list view, so removing the column from list view as this information is available in a nice tree view on the details view of a Catalog Item. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1740172
Due to enhancement made in ManageIQ#5445 , Now list of tenant can be lot of tenant names and may not fit properly on the list view, so removing the column from list view as this information is available in a nice tree view on the details view of a Catalog Item. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1740172
RFE:
https://bugzilla.redhat.com/show_bug.cgi?id=1678123
Tracking issue:
ManageIQ/manageiq#18553
How to test:
or
select some Item from the list and Configuration > Edit Selected Item
=> Catalog Item Edit page is displayed, with the new Additional Tenants option
TODO:
all PRs in In Service: select Tenants where the service will be available manageiq#18553 need to be merged/finishedgenerate the proper tree with just Tenants + checkboxesadd angular support for saving selected Tenants (Ansible Playbook Catalog Item type)solve saving selected Tenants:for angular screenfor non-angular screensolve displaying created/edited Catalog Items with additional tenantssolve displaying checked Tenants in the tree while displaying the Catalog Item's infomake the tree unclickable while displaying the Catalog Item's infotree for Catalog Item Type Ansible Playbook is not clickable :( (angular), while adding/editing the item(we need Allow angular in layouts/tree #5562 to be merged)fix failing specs and add some morefix issue regarding Save button while editing selected Tenants (while editing existing Catalog Item)(Save button does not respond properly)
make Save button responsive, in the angular screen (Ansible Playbook Catalog Item type)make the tree work also for Catalog Bundles, when:adding new Catalog Bundleediting an existing Catalog Bundledisplaying Catalog Bundle's infoBefore:
Adding Catalog Item of Catalog Item Type: Amazon
Adding Catalog Item of Catalog Item Type: Ansible Playbook
Displaying info for Catalog Item of Catalog Item Type: Amazon (checkboxes unclickable)
After:
Adding Catalog Item of Catalog Item Type: Amazon
Adding Catalog Item of Catalog Item Type: Ansible Playbook
Displaying info for Catalog Item of Catalog Item Type: Amazon (checkboxes unclickable)