Fix the access to child services from parents under My Services #5384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I hid the services in #5335 we didn't count with the fact that services might be nested into each other. Unfortunately, the child service access is only doable through the
tree_select
route and it has been accessed bymiqTreeActivateNode
. Without the node actually being in the tree, this function did nothing and so the child services weren't accessible.I'm proposing a workaround to call the
tree_select
directly from themiqTreeSelect
function. This is not a permanent solution, these areas where we access items exclusively throughtree_select
should be refactored.Navigating back to the parent service in hammer can be done using the toolbar's back button, in upstream we should also update the breadcrumb generation logic to contain the hierarchy.
@miq-bot add_label bug, trees, services, hammer/yes
@miq-bot add_reviewer @martinpovolny
@miq-bot add_reviewer @himdel
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1693264