Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the access to child services from parents under My Services #5384

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

skateman
Copy link
Member

When I hid the services in #5335 we didn't count with the fact that services might be nested into each other. Unfortunately, the child service access is only doable through the tree_select route and it has been accessed by miqTreeActivateNode. Without the node actually being in the tree, this function did nothing and so the child services weren't accessible.

Screenshot from 2019-03-27 13-37-40

I'm proposing a workaround to call the tree_select directly from the miqTreeSelect function. This is not a permanent solution, these areas where we access items exclusively through tree_select should be refactored.

Navigating back to the parent service in hammer can be done using the toolbar's back button, in upstream we should also update the breadcrumb generation logic to contain the hierarchy.

Screenshot from 2019-03-27 13-40-25

@miq-bot add_label bug, trees, services, hammer/yes
@miq-bot add_reviewer @martinpovolny
@miq-bot add_reviewer @himdel

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1693264

@himdel
Copy link
Contributor

himdel commented Mar 27, 2019

LGTM either way..

@skateman skateman force-pushed the notify-child-services branch from 3a2b9b8 to 7881d82 Compare March 28, 2019 08:21
@miq-bot
Copy link
Member

miq-bot commented Mar 28, 2019

Checked commit skateman@7881d82 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@himdel himdel merged commit 643b1da into ManageIQ:master Mar 28, 2019
@himdel himdel added this to the Sprint 108 Ending Apr 1, 2019 milestone Mar 28, 2019
@himdel himdel self-assigned this Mar 28, 2019
@skateman skateman deleted the notify-child-services branch March 28, 2019 14:05
simaishi pushed a commit that referenced this pull request Mar 29, 2019
Fix the access to child services from parents under My Services

(cherry picked from commit 643b1da)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1693749
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit b0f0e2b853a549ebd7e6c41c0e8967781b1bd7df
Author: Martin Hradil <[email protected]>
Date:   Thu Mar 28 14:04:49 2019 +0000

    Merge pull request #5384 from skateman/notify-child-services
    
    Fix the access to child services from parents under My Services
    
    (cherry picked from commit 643b1da108a297b5147c65df5062eafd67af8367)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1693749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants