Fix preselect node in servers by roles tree under diagnostics #5382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: LGTM 👍 @skateman Travis failure is related. |
skateman
force-pushed
the
server-roles-highlight
branch
from
6a893e4 to
cc755a9
Compare
This is as inconsistent behavior, there should be a preselected node with its details shown on the right side. The right side data was all there, however, the appropriate node was not highlighted.
skateman
force-pushed
the
server-roles-highlight
branch
from
cc755a9 to
5c0e8cf
Compare
|
Checked commit skateman@5c0e8cf with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
ZitaNemeckova
approved these changes
Mar 27, 2019
|
@miq-bot assign @mzazrivec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is as inconsistent behavior, there should be a preselected node with its details shown on the right side. The right side data was all there, however, the appropriate node was not highlighted. Now when you navigate to the page, it should preselect the node.
@miq-bot add_reviewer @ZitaNemeckova
@miq-bot add_label bug, trees