Decorator update for inventory and credentials #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgalis
force-pushed
the
decorator_update_for_inventory
branch
from
7ab4d08 to
2178a84
Compare
|
/cc @himdel, @mzazrivec |
himdel
reviewed
Mar 2, 2017
| @@ -1,5 +1,5 @@ | |||
| module ManageIQ::Providers::AutomationManager | |||
| class InventoryRootGroupDecorator < MiqDecorator | |||
| module ManageIQ::Providers | |||
There was a problem hiding this comment.
@lgalis the same change will be needed in app/decorators/manageiq/providers/automation_manager/inventory_group_decorator.rb as well.
|
Except for that one missing decorator, agreed completely, LGTM 👍 |
|
Made the same change for the InventoryGroup decorator |
|
Checked commits lgalis/manageiq-ui-classic@8467ddf~...8b70d2c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
himdel
approved these changes
Mar 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decorator update for inventory and credentials - follow up for #237
https://bugzilla.redhat.com/show_bug.cgi?id=1428279