Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display IDs of VMs,Reports,Result,... #5342

Merged
merged 4 commits into from
Apr 4, 2019

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented Mar 14, 2019

Description of problem
When used with Service Now Portal, CFME is communicating over API with IDs of VMs, Reports, Report results, etc. When something is needed to be troubleshooted, or checked, the user needs also to go to the API and drill for the names. This makes troubleshooting efforts difficult and slow.

Actual results
No item IDs visible in the GUI.

Expected results
Item IDs visible in the GUI.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1638245

Additional info
BZ targets CloudForms 4.6 so if merge PR need to be backport to 4.6 as well

@martinpovolny opened up a new PR with changes in #4791 with a fix for your comment #4791 (comment)
Please take a look.

@miq-bot
Copy link
Member

miq-bot commented Mar 14, 2019

Checked commits h-kataria/manageiq-ui-classic@333901d~...c387a0e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
7 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@Loicavenel
Copy link

@h-kataria, can I get a screenshot? is it going to be in Listview?

@h-kataria
Copy link
Contributor Author

h-kataria commented Mar 15, 2019

@Loicavenel before/after screenshots are in original PR #4791 (review)

@h-kataria
Copy link
Contributor Author

@Loicavenel additionally id column was added to following list views
saved_reports_with_id

Screenshot from 2019-03-15 09-20-19

Screenshot from 2019-03-15 09-20-42

@Loicavenel
Copy link

@h-kataria is it just for Reporting?

@h-kataria
Copy link
Contributor Author

h-kataria commented Mar 15, 2019

@Loicavenel the original creator of the PR has added ID column on list views for saved reports, list of widgets, and on Role/User/Group/VM details screens.
It can be added to any other screens. My intents was to address @martinpovolny comment in the PR that was not addressed by the original PR creator so to get this PR merged i took a stab at addressing the issue.

@Loicavenel
Copy link

Ok, I think it is ok.. I know some customers complained about all the data we show that are not pertinent for End-User...

@martinpovolny martinpovolny added this to the Sprint 109 Ending Apr 15, 2019 milestone Apr 4, 2019
@martinpovolny martinpovolny merged commit 0e5e167 into ManageIQ:master Apr 4, 2019
@h-kataria h-kataria deleted the pr/4791 branch April 9, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants