Add safeguard for VMs without ext_management_system #5339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PanSpagetka you can get into such state with orphaned VMs, not sure how exactly that can happen but we have support for it. Maybe if you provision a VM through a service, retire it (becomes archived) and then drop its provider. But this is just a guess. |
skateman
suggested changes
Mar 15, 2019
|
Checked commit PanSpagetka@3f4ae45 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Mar 29, 2019
Add safeguard for VMs without ext_management_system (cherry picked from commit aa5d916) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1693730
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If VM doesn't have ExtManagemntSystem UI blows up, so I have added safeguard for that. However I am not sure if it should be possible to get into such state.
Links [Optional]
https://bugzilla.redhat.com/show_bug.cgi?id=1684649
Steps for Testing/QA [Optional]
Have a VM that doesn't belong to ExtManagemntSystem
Go to Network -> Topology