Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unhandled promise catch in catalog form #5308

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Mar 5, 2019

Description

Adds missing catch blocks to promises in Catalog form.

It caused error messages is tests.

Before

(node:27486) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'resources' of undefined
(node:27486) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 4)
(node:27486) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

After

@rvsia
Copy link
Contributor Author

rvsia commented Mar 5, 2019

@Hyperkid123

@miq-bot add_label hammer/no, services, react

@miq-bot
Copy link
Member

miq-bot commented Mar 5, 2019

Checked commit rvsia@afd81d8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec mzazrivec requested a review from Hyperkid123 March 6, 2019 06:44
@mzazrivec mzazrivec self-assigned this Mar 11, 2019
@mzazrivec mzazrivec added this to the Sprint 107 Ending Mar 18, 2019 milestone Mar 11, 2019
@mzazrivec mzazrivec merged commit a1a16bb into ManageIQ:master Mar 11, 2019
@rvsia rvsia deleted the fix-catalog-tests branch September 17, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants