Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable provision instances button via providers #53

Merged
merged 3 commits into from
Jan 6, 2017

Conversation

bmclaughlin
Copy link
Contributor

This is the Instances version of #11836 and moved from the ManageIQ repo PR ManageIQ/manageiq#13152

https://bugzilla.redhat.com/show_bug.cgi?id=1386342

@bmclaughlin
Copy link
Contributor Author

@miq-bot add_label ui, bug

@bmclaughlin
Copy link
Contributor Author

@mzazrivec, @skateman Thanks for the review and suggestion on the spec (implemented!).

@miq-bot
Copy link
Member

miq-bot commented Jan 5, 2017

@bmclaughlin Cannot apply the following label because they are not recognized: ui

@miq-bot miq-bot added the bug label Jan 5, 2017
@mzazrivec mzazrivec self-assigned this Jan 5, 2017
@mzazrivec
Copy link
Contributor

Could you please address ManageIQ/manageiq#13152 (comment) ?

@miq-bot
Copy link
Member

miq-bot commented Jan 5, 2017

Checked commits bmclaughlin/manageiq-ui-classic@aa51122~...4ef7e51 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 0 offenses detected
Everything looks good. 🍰

@mzazrivec mzazrivec added this to the Sprint 52 Ending Jan 16, 2017 milestone Jan 6, 2017
@mzazrivec mzazrivec merged commit b30561c into ManageIQ:master Jan 6, 2017
@bmclaughlin bmclaughlin deleted the miq_pr_13152 branch January 6, 2017 16:08
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit d9fe1d88fad71bd37fecbe04b8455829312299a4
Author: Milan Zázrivec <[email protected]>
Date:   Fri Jan 6 14:25:57 2017 +0100

    Merge pull request #53 from bmclaughlin/miq_pr_13152
    
    Enable provision instances button via providers
    (cherry picked from commit b30561c62a2e9979f6367ce12bcc07a3111cd372)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1386342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants