Dialog Editor - rework tree params, *don't* pre-initialize the tree #5267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, looking forward to the ui-components change. Also there are some issues in the automate land with parsing the fqdn (see the BZ). |
expected methods: * load() -> Promise(data) * lazyLoad(node) -> Promise(data) https://bugzilla.redhat.com/show_bug.cgi?id=1553846
used to initialize the tree with the right node expanded treeOptions.load now accepts an optional fqdn argument https://bugzilla.redhat.com/show_bug.cgi?id=1553846
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/afa4734fa37253a471249e8b783a20387aeafee5~...c97834dcacef1c68b1a1a4cc201e168f4b567b14 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot remove_label wip |
miq-bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automation > Automate > Customization, add/edit a dialog
https://bugzilla.redhat.com/show_bug.cgi?id=1553846
When editing dynamic field details in the dialog editor, the tree gets loaded before any field data is available, so it can't expand the active node, because it doesn't know it.
This, along with ManageIQ/ui-components#369 makes it possible to delay the tree initialization until the tree gets displayed.
Depends on ManageIQ/ui-components#369 and will need (a @skateman PR adding
?fqdnsupport to/tree/automate_entrypoint) for the preselection to work.(Feel free to merge #5267 + ManageIQ/ui-components#369 together, the endpoint PR can be separate.)
Cc @skateman