Use ljust to left justify and pad strings

[jrafanie]

Text based reports ignore line widths. Performing manual padding was
causing a "negative argument" error if a line exceeded the normal
report's line width.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1677839

[jrafanie]

@miq-bot add_label bug

[jrafanie]

cc @gtanzillo

[mzazrivec]

Current CI failures seem related:

ReportFormatter::ReportText expands report width for really long filter condition
     Failure/Error: expect(line.strip).to eq(expected.lines[index].strip)
     
       expected: "|( Performance - VM : Activity Sample - Timestamp (Day/Time) IS \"Last Hour\" AND Performance - VM : CPU - Usage Rate for Collec>>"
            got: "|( Performance - VM : Activity Sample - Timestamp (Day/Time) IS \"Last Hour\" AN>>"
     
       (compared using ==)
     # ./spec/lib/report_formater/text_formatter_spec.rb:29:in `block (4 levels) in <top (required)>'
     # ./spec/lib/report_formater/text_formatter_spec.rb:28:in `each'
     # ./spec/lib/report_formater/text_formatter_spec.rb:28:in `each_with_index'
     # ./spec/lib/report_formater/text_formatter_spec.rb:28:in `block (3 levels) in <top (required)>'
     # ./spec/lib/report_formater/text_formatter_spec.rb:11:in `block (2 levels) in <top (required)>'

[jrafanie]

yeah, @mzazrivec, interesting... they pass locally... I wonder if another test is modifying class ivars. I'll fix it up and let you know when it's ready to go.

[miq-bot]

Checked commit jrafanie@10f082f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

[jrafanie]

ok @mzazrivec, it's ready to go. I had to change the test to ensure it was testing the scenario in which it was not truncating long lines. Thanks!

[mzazrivec]

@jrafanie changes look good, thanks.

Also, I hope you did not get too puzzled by Чук and Гек.

[simaishi]

Hammer backport details:

$ git log -1
commit 6fce3b0530688344df75cb5d460222956f07bdff
Author: Milan Zázrivec <[email protected]>
Date:   Thu Feb 21 08:11:36 2019 +0100

    Merge pull request #5254 from jrafanie/fix_padding_calculation_since_text_ignores_line_width
    
    Use ljust to left justify and pad strings
    
    (cherry picked from commit 805c1944ce9bdfbbee6bb3f54a179d036908e631)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1693727