Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to print (export to PDF) the right size recommendations of a VM #5252

Merged
merged 2 commits into from
Feb 20, 2019

Conversation

skateman
Copy link
Member

Right size recommendations can be accessed from a VM's summary screen under the Configuration dropdown in the toolbar.

screenshot from 2019-02-19 08-53-33

I created a new toolbar on this page with the print button and a new route that displays the printing dialog. However, it is a little weird to have the button completely on the left side of the toolbar. I don't feel it as consistent, but as far as I see, it is always aligned to the left, but on other pages there are multiple buttons pushing it more to the right.

screenshot from 2019-02-19 08-49-25

The printing follows the same logic as on summary screens, a new window with the printing dialog opened. If you close the printing dialog, the window will close with it so you can get back to the previous page.

@miq-bot add_label enhancement

https://bugzilla.redhat.com/show_bug.cgi?id=1430159

@skateman skateman changed the title [WIP] Allow to print (export to PDF) the right size recommendations of a VM Allow to print (export to PDF) the right size recommendations of a VM Feb 19, 2019
@miq-bot
Copy link
Member

miq-bot commented Feb 19, 2019

Checked commits skateman/manageiq-ui-classic@00a6caf~...8d60e8a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 3 offenses detected

app/controllers/vm_common.rb

app/helpers/application_helper/toolbar/right_size_view.rb

  • ❗ - Line 12, Col 3 - Layout/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 3, Col 5 - Layout/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

@miq-bot miq-bot removed the wip label Feb 19, 2019
@mzazrivec mzazrivec self-assigned this Feb 20, 2019
@mzazrivec mzazrivec added this to the Sprint 106 Ending Mar 4, 2019 milestone Feb 20, 2019
@mzazrivec mzazrivec merged commit acbc8c2 into ManageIQ:master Feb 20, 2019
@skateman skateman deleted the print-right-size branch February 20, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants