Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add icon for ansible credentials #525

Merged
merged 1 commit into from
Mar 1, 2017
Merged

add icon for ansible credentials #525

merged 1 commit into from
Mar 1, 2017

Conversation

epwinchell
Copy link
Contributor

This is a follow-up to: #452

@epwinchell
Copy link
Contributor Author

@miq-bot add_label graphics, euwe/no, enhancement

@epwinchell
Copy link
Contributor Author

cc @mzazrivec

@epwinchell
Copy link
Contributor Author

@miq-bot assign @himdel

@miq-bot
Copy link
Member

miq-bot commented Mar 1, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/ba1b1f87ea0978b67d07864899f28ade4ee5ae87 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍪

@martinpovolny
Copy link
Member

@epwinchell : should we also delete the listicon_image method?

@epwinchell
Copy link
Contributor Author

@martinpovolny No, it's still used by the quadicons

@martinpovolny martinpovolny merged commit 658361e into ManageIQ:master Mar 1, 2017
@martinpovolny martinpovolny added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 1, 2017
@epwinchell epwinchell deleted the ansible_credentials_icon branch October 25, 2017 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@himdel himdel

Labels
enhancement graphics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@epwinchell @miq-bot @martinpovolny @himdel