Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing flash message for Re-check Authentication Status #5243

Merged

Conversation

hstastna
Copy link

@hstastna hstastna commented Feb 13, 2019

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1667980

What:
Fix the missing flash message (or better missing flash message div) for re-checking authentication status (and another actions) for selected Container Provider, under Compute > Containers > Providers.

Steps to reproduce:

  1. Have some Openshift Provider and go to Compute > Containers >Providers
  2. Choose some provider, click on it, display its details page
  3. On the Dashboard view, select Authentication > Re-check Authentication Status
    => nothing is displayed, just error about missing flash message div, in the right upper corner

Before: (no flash message, error)
auth_before

After: (flash message appears also for another actions/operations)
auth_after
check_after
refresh_after

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1667980

Fix the missing flash message for re-checking authentication status
for selected Container Provider, under Compute > Containers > Providers.
@hstastna
Copy link
Author

@miq-bot add_label bug, blocker, hammer/yes

@miq-bot
Copy link
Member

miq-bot commented Feb 13, 2019

Checked commit hstastna@e8ff8e2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@h-kataria h-kataria self-assigned this Feb 13, 2019
@h-kataria h-kataria added this to the Sprint 105 Ending Feb 18, 2019 milestone Feb 13, 2019
@h-kataria h-kataria merged commit 0b62dfa into ManageIQ:master Feb 13, 2019
simaishi pushed a commit that referenced this pull request Mar 8, 2019
…_Auth_Status

Fix missing flash message for Re-check Authentication Status

(cherry picked from commit 0b62dfa)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1686984
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2019

Hammer backport details:

$ git log -1
commit d43c773bf5326a3703d192bafb16c1bff231a5b3
Author: Harpreet Kataria <[email protected]>
Date:   Wed Feb 13 16:42:22 2019 -0500

    Merge pull request #5243 from hstastna/Missing_flash_message_Re-check_Auth_Status
    
    Fix missing flash message for Re-check Authentication Status
    
    (cherry picked from commit 0b62dfa802fb6b6327887070c3588ad2700e77a9)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1686984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants