Fix usage of TreeBuilder.extract_node_model_and_id in OpcControler #5142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TreeBuilder.extract_node_model_and_id(params[:id].to_s) returns id in second element and we had typo in spec. params[:id] has format "tn-ID"
|
Checked commit lpichler@16ee360 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label hammer/yes, blocker |
|
(Backport after #5129 please.) |
simaishi
pushed a commit
that referenced
this pull request
Jan 14, 2019
Fix usage of TreeBuilder.extract_node_model_and_id in OpcControler (cherry picked from commit c10ecc3) https://bugzilla.redhat.com/show_bug.cgi?id=1468795
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix displaying menu "Manage Tenant Quota" from #5123
params[:id]has format"tn-ID"(not"tn_ID")method
TreeBuilder.extract_node_model_and_id(params[:id].to_s)returns
idin second element:TreeBuilder.extract_node_model_and_id("tn-33333")returns
[nil,"33333", "tn"]and we had case written with
'_'in specsLinks
@miq-bot add_label bug