Converted Catalog form

[rvsia]

Description

Converts Services > Catalogs > Catalogs > Configuration > New/Edit to data-driven forms

• added <hr> component to DDR
• fixes duallist helper methods (because of changes of format in duallist)

Before

After

Checklist

• Schema
• Form component
• Tests
• Clean up old ruby code (I hope 🙏 )

[rvsia]

@miq-bot add_label hammer/no, services, react, refactoring

[rvsia]

@ZitaNemeckova fixed! 👍

[ZitaNemeckova]

@rvsia Try to save a Catalog with a name of existing one


This should be without popup window like on master + comment 👇#5139 (comment)

Otherwise it works perfectly in UI 👍

[terezanovotna]

When we show message "name has been already taken", we need to show what area of UI this message refers to. If we had more fields, the user would have no idea where the error occured.

[Hyperkid123]

When we show message "name has been already taken", we need to show what area of UI this message refers to.

You mean something like focus the field for instance?

[terezanovotna]

show in the form what exact area needs to be edited or changed. Example is here

[terezanovotna]

[rvsia]

@ZitaNemeckova Great catch! Fixed the error message (@Hyperkid123 please re-re-review catch blocks 🙏 ), and I was trying to get any other error to test it, but this seems as only one which is possible to get from API. Is that right?

[ZitaNemeckova]

@rvsia I think so. I tried every possible combination and this was only API error I got.

[rvsia]

@ZitaNemeckova Ok, great! Thanks!

[Hyperkid123]

@terezanovotna what about async validation? Meaning instead of waiting for submit the form would check the availability of the name (or whatever) when the user is typing?
It might sound strange but from implementation perspective that would be easier.

[terezanovotna]

that sounds as an even better solution

[miq-bot]

Checked commits rvsia/manageiq-ui-classic@ac2345d~...98b9917 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

[rvsia]

@martinpovolny There is an issue with errors in this form:

When you add a new Catalog with used name it returns 400 error
When you edit some Catalog and change its name to used name it returns 500 error

Do you know to whom address this issue?

[Hyperkid123]

I think this one is good to go. @martinpovolny can we merge this one? I think all possible bugs have been taken care of.

@terezanovotna Ok we will design some sane way to make this. We will do it in different PR because we want to make a global solution that can be used in future. Right now the form behaves the same way as before and we will add the async validation ASAP.

[himdel]

@rvsia

When you edit some Catalog and change its name to used name it returns 500 error

Can you please open a manageiq-api issue, with the backtrace?

EDIT: ManageIQ/manageiq-api#574

[rvsia]

@himdel ok! 👍