Fix enabling Power operations for a template

[hstastna]

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1634713
https://bugzilla.redhat.com/show_bug.cgi?id=1655477

What:
This PR fixes the problem about the Power operations which were enabled for a template. And Power operations don't make sense for a template. They should be enabled only for VMs.

Steps to reproduce:

1. Go to Compute > Infrastructure > VMs > VMs & Templates accordion > All VMs & Templates
2. Select some template (not VM!) by checking its checkbox
3. In the toolbar, choose Power > Power On or any other Power action
   => flash message about the start (for example) which was initiated successfully appears and it shouldn't

---

Before:

After:

Note:
I've removed appropriate power actions from untestable actions array in testable_action method which did not make sense to be there. Now the power actions should work properly for VMs and Templates. I've tested power operations for VMs and everything works as usually. And for Templates, the right flash message appears.

[hstastna]

@miq-bot add_label bug, hammer/yes, blocker

[mzazrivec]

@hstastna The current CI failures seem related.

[martinpovolny]

So you are removing reboot_guest stop start suspend reset shutdown_guest from the list of the vm_infra_untestable_actions.

@romanblanco added that exceptions for some reason. I am not sure why. I assume that the records_support_feature? would not for for those as it was not supposed by the backend/core.

We need to check what toolbars include these actions. Make a list of pairs entity (such as Instance, VM, Image, ...), action, that can be called (from the buttons below app/helpers/application_helper/toolbar/ ).

For each such pair (that can be called) we must make sure that the code works.

I cannot think about any other reason why @romanblanco added the exceptions (and I dimly remember that there was some problem with checking the availability of those actions on the backend via supports_* or [do not remember the 2nd mechanism]).

If all the combination are ok, we can merge this. W/o this thorough testing we cannot be sure that we are not breaking something here.

[martinpovolny]

Seems that due to the test if controller == "vm_infra" on line https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/application_controller/ci_processing.rb#L644 the number of toolbars that need to be checked is limited.

However there will be toolbars for nested entities and these need to be checked too.

[hstastna]

It looks like it is only about x_vm_center and vm_infras_center toolbars, if we talk about vm_infra controller. I haven't found any other toolbars related to Power operations and the controller. And for all nested entities, the controller is different, not vm_infra.
I think that the fix should be ok. I haven't found any problems with that anywhere.

And I've found couple of bugs while testing, but unrelated to this PR, for example:

1. go to Compute > Infra > Datastores
2. click on some datastore to display its details page
3. click on Managed VMs in the table in the details page (it is required to have some VMs there, not 0)
4. select some VM(s) by checking its/their checkbox(es)
5. choose any action under Power operations or Lifecycle > Retire selected items
   =>

[----] F, [2019-01-10T18:50:18.179377 #27579:2aef7da40a28] FATAL -- : Error caught: [ActiveRecord::RecordNotFound] Can't access selected records
/home/hstastna/manageiq/manageiq-ui-classic/app/controllers/mixins/checked_id_mixin.rb:60:in `find_records_with_rbac'
/home/hstastna/manageiq/manageiq-ui-classic/app/controllers/application_controller/ci_processing.rb:620:in `generic_button_operation'
/home/hstastna/manageiq/manageiq-ui-classic/app/controllers/application_controller/ci_processing.rb:405:in `retirevms_now'
/home/hstastna/manageiq/manageiq-ui-classic/app/controllers/application_controller/ci_processing.rb:959:in `process_vm_buttons'
/home/hstastna/manageiq/manageiq-ui-classic/app/controllers/storage_controller.rb:93:in `button'

Maybe some other operations will not work properly there. And maybe the BZ for this already exists.

[martinpovolny]

Ok, will you remove the "WIP label and fix the specs so that we can move this one forward? Thx!

[hstastna]

@skateman I think you can review the specs ;) Thank you!

[skateman]

Hmm, what about not doing this, and just adding something like:

Zone.my_zone

Maybe the method name is not the right one, but I'm pretty sure there's a method to retrieve the current zone.

[hstastna]

I realized that this was not necessarry. Thank you, David.

[hstastna]

@miq-bot remove_label wip

[skateman]

I like it now, but I don't see any tests that cover the power operations for the template. Can you please point them out for me, or if they're not there add them?

[hstastna]

The 2nd commit takes care of it but not directly so probably this is not exactly what you expect and maybe I should add very similar specs as there are already for VMs, for vm_infra controller.

[skateman]

@hstastna please do so

[miq-bot]

Checked commits hstastna/manageiq-ui-classic@74b2cf8~...0643df5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍪

[skateman]

[simaishi]

Hammer backport details:

$ git log -1
commit c0dff2f40c665c4f42438f94f16e4e968127c8d6
Author: Milan Zázrivec <[email protected]>
Date:   Mon Feb 18 08:12:19 2019 +0100

    Merge pull request #5128 from hstastna/Power_dropdown_enabled_for_template
    
    Fix enabling Power operations for a template
    
    (cherry picked from commit 8bf2ad4efb7acd3e50b9ac0c9b822eca9ae129eb)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1686012
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1686015