Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added i18n form data-driven-forms default validation messages. #5068

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

Hyperkid123
Copy link
Contributor

Added validators translation config for data-driven-forms. Every validator has its default message. So far, we are using only Required validation in forms. But that will soon change.

screenshot from 2018-12-10 09-05-25

@Hyperkid123
Copy link
Contributor Author

@miq-bot assign @martinpovolny
@miq-bot add_reviewer @himdel

@miq-bot
Copy link
Member

miq-bot commented Dec 10, 2018

Checked commit Hyperkid123@dab8faf with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@himdel himdel added this to the Sprint 101 Ending Dec 17, 2018 milestone Dec 11, 2018
@himdel himdel merged commit 4cdb164 into ManageIQ:master Dec 11, 2018
@himdel
Copy link
Contributor

himdel commented Dec 11, 2018

Data driven forms are all hammer/no, right?

@Hyperkid123
Copy link
Contributor Author

@himdel yep hammer/no (should have added it...)

@Hyperkid123
Copy link
Contributor Author

@miq-bot add_label hammer/no

@Hyperkid123 Hyperkid123 deleted the ddforms-i18n branch November 12, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants