Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring > Alerts - sparkle when loading #5066

Merged
merged 3 commits into from
Dec 10, 2018
Merged

Monitoring > Alerts - sparkle when loading #5066

merged 3 commits into from
Dec 10, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Dec 7, 2018

Monitoring > Alerts > (each section):

Added a spinner that starts spinning when angular loads, and stops when the screen has loaded all the data.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1507011


the other 2 commits just fix eslint warnings in the code

Added a spinner that starts spinning when angular loads, and stops when the screen has loaded all the data

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1507011
the parameter is never set to anything but undefined,
and never referenced in the target function,
removing
@miq-bot
Copy link
Member

miq-bot commented Dec 7, 2018

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/c00314ca18faa0e56fba76af4d63ca9a3a54840e~...322ab2074eb887c0f9ca78f367459acbdc707f1e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec self-assigned this Dec 10, 2018
@mzazrivec mzazrivec added this to the Sprint 101 Ending Dec 17, 2018 milestone Dec 10, 2018
@mzazrivec mzazrivec merged commit 61bfd22 into ManageIQ:master Dec 10, 2018
@himdel himdel deleted the monitoring-sparkle branch December 10, 2018 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants