TenantComponent - fix setting default based on ancestry #5031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ManageIQ/manageiq-api#253, the API is not returning undefined, but null. That causes the "Use Configuration Settings" checkbox to never get shown. (It should only appear for root tenants.) Fixing to handle both. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1641778 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1654718
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/dfc48b298225f86430f234a7d7d9efeb7a58af09 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Dec 4, 2018
TenantComponent - fix setting default based on ancestry (cherry picked from commit 189dfe3) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1641778 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1654718
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ops > Access Control > Tenants .. click the root tenant & edit
Since ManageIQ/manageiq-api#253,
the API is not returning undefined, but null. (When no ancestry found.)
That causes the "Use Configuration Settings" checkbox to never get shown.
(It should only appear for root tenants.)
Fixing to handle both.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1641778
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1654718