Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service catalog icon fix #5017

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Service catalog icon fix #5017

merged 1 commit into from
Dec 3, 2018

Conversation

epwinchell
Copy link
Contributor

The Service Catalog Order screen was showing "pficon-template" as the default icon rather than "fa-cube." This PR corrects that and also resizes the icon.

Old
screen shot 2018-11-30 at 10 17 54 am

New
screen shot 2018-11-30 at 10 17 31 am

https://bugzilla.redhat.com/show_bug.cgi?id=1518867

@epwinchell
Copy link
Contributor Author

@miq-bot add_label bug, hammer/yes, graphics

@epwinchell
Copy link
Contributor Author

@miq-bot add_label gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Nov 30, 2018

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/04901e84574b84c7036596a8097d2df51d61a79b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec mzazrivec self-assigned this Dec 3, 2018
@mzazrivec mzazrivec added this to the Sprint 100 Ending Dec 3, 2018 milestone Dec 3, 2018
@mzazrivec mzazrivec merged commit ab3ddcf into ManageIQ:master Dec 3, 2018
simaishi pushed a commit that referenced this pull request Dec 3, 2018
@simaishi
Copy link
Contributor

simaishi commented Dec 3, 2018

Hammer backport details:

$ git log -1
commit b177da0c971a0071d893647cc53ba5a5316e7041
Author: Milan Zázrivec <[email protected]>
Date:   Mon Dec 3 09:04:32 2018 +0100

    Merge pull request #5017 from epwinchell/1518867
    
    Service catalog  icon fix
    
    (cherry picked from commit ab3ddcf1c0a132ec30281ff1e65195c89abba566)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1518867

@epwinchell epwinchell deleted the 1518867 branch March 20, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants