Add top row information into the storage manager quadicons

[skateman]

There's no separate STI class for block & object storage managers, so I had to do this ugly hack while adding the missing information to the quadrants.

Before:

After:

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650086

@miq-bot add_label GTLs, hammer/yes, bug
@miq-bot add_reviewer @epwinchell

[JPrause]

@miq-bot add_label blocker

[epwinchell]

Tested. Looks good.

[skateman]

I'm still missing the object storage quadrants from @Loicavenel.

[Loicavenel]

@skateman there is only one option available: Cloud object store containers .. Put that on the top left

[skateman]

Thanks @Loicavenel, updated

[martinpovolny]

@skateman : a small spec? for the new method?

[skateman]

@martinpovolny there's no new method and I'm against writing specs for declarative stuff like decorators. I can surely test if 1 = 1, but I think just turning off the coverage for the declarations makes more sense. Also the asset pipeline is turned off in testing, so some of the decorator specs would be really just 1 = 1...

This special case of storage with the decision logic is wrong and I would like to get rid of it, just haven't figured out how to do so.

[martinpovolny]

@skateman : I'm sorry, but it's not that simple. You are adding code to a method that has no specs. You are adding conditions, you are calling other methods. This method is no longer a trivial declaration.

I suggest that you add a very simple spec. I do not actually care what the spec tests, I don't want you to test this condition or that. I want at least this piece of code to be called from the test suite. I want a test that failed if I remove the code or if I call a non-existent method there.

For example if you create a situation where supports_block_storage? would be true you and call the method just once, you will get > 50% of the lines executed. The check if a hash with 2 expected keys is returned and we have at least something.

Or make sure that the method is called as part of a more complex scheme, where more of decorator would be used.

Pls, do not make PRs that decrease test coverage. Not even a little ;-)

[skateman]

@martinpovolny done

[miq-bot]

Checked commit skateman@e16922e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

[simaishi]

Hammer backport details:

$ git log -1
commit 59ca8e385312fef66beb20d36381204b53702f16
Author: Martin Povolny <[email protected]>
Date:   Tue Dec 4 15:43:50 2018 +0100

    Merge pull request #4987 from skateman/storage-manager-quad
    
    Add top row information into the storage manager quadicons
    
    (cherry picked from commit c6662afdd9e0f71f11aff58e8486c4f956dfae06)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650086