Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the web console for OpenStack instances #4960

Merged
merged 1 commit into from
Nov 22, 2018

Conversation

skateman
Copy link
Member

@skateman skateman commented Nov 22, 2018

There was a little confusion around web console, after a discussion with @aufi he stated that it needs to be visible for OpenStack instances as well, so removing the piece of code that hides it.

Before:
screenshot from 2018-11-22 10-13-24

After:
screenshot from 2018-11-22 10-12-38

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650470

@miq-bot add_reviewer @martinpovolny
@miq-bot add_label gaprindashvili/no, hammer/yes, bug

@martinpovolny martinpovolny merged commit e384419 into ManageIQ:master Nov 22, 2018
@martinpovolny martinpovolny self-assigned this Nov 22, 2018
@martinpovolny martinpovolny added this to the Sprint 100 Ending Dec 3, 2018 milestone Nov 22, 2018
@skateman skateman deleted the display-cockpit-openstack branch November 22, 2018 12:53
simaishi pushed a commit that referenced this pull request Nov 26, 2018
Display the web console for OpenStack instances

(cherry picked from commit e384419)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650470
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 251928d39a326f976af043cc079ee8350379f708
Author: Martin Povolny <[email protected]>
Date:   Thu Nov 22 13:50:11 2018 +0100

    Merge pull request #4960 from skateman/display-cockpit-openstack
    
    Display the web console for OpenStack instances
    
    (cherry picked from commit e384419913ffc8e97e166280b1d91159ebeaccf7)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants