Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't translate audit messages #4952

Merged

Conversation

mzazrivec
Copy link
Contributor

Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

msg = if emss.length == 1
"'%{task}' successfully initiated for %{model}" % msg_params
else
"'%{task}' successfully initiated for %{models}" % msg_params
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong indent :-(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@mzazrivec mzazrivec force-pushed the dont_translate_audit_messages branch from 40a5361 to 4090c74 Compare November 23, 2018 14:00
@miq-bot
Copy link
Member

miq-bot commented Nov 23, 2018

Checked commits mzazrivec/manageiq-ui-classic@e2a64ab~...4090c74 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@martinpovolny martinpovolny self-assigned this Nov 23, 2018
@martinpovolny martinpovolny added this to the Sprint 100 Ending Dec 3, 2018 milestone Nov 23, 2018
@martinpovolny martinpovolny merged commit 7cf753b into ManageIQ:master Nov 23, 2018
@mzazrivec mzazrivec deleted the dont_translate_audit_messages branch November 23, 2018 15:14
simaishi pushed a commit that referenced this pull request Nov 27, 2018
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 8039fe91d9be969a1953f719af811d26fd4f391f
Author: Martin Povolny <[email protected]>
Date:   Fri Nov 23 15:43:27 2018 +0100

    Merge pull request #4952 from mzazrivec/dont_translate_audit_messages
    
    Don't translate audit messages
    
    (cherry picked from commit 7cf753b40c73b3df183805931695503f20e658f7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1548389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants