Do not store download_summary_pdf using remember tab #4945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@3830bbd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 26, 2018
Do not store download_summary_pdf using remember tab (cherry picked from commit 297ba8b) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649867
|
Hammer backport details: |
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Aug 7, 2019
Extended change made in ManageIQ#4945 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1738664
pkomanek
pushed a commit
to pkomanek/manageiq-ui-classic
that referenced
this pull request
Aug 20, 2019
Extended change made in ManageIQ#4945 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1738664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
exporting to PDFprinting a textual summary of a VM or instance, theexport to PDFprinting screen gets remembered as the last action for that particular menu hierarchy. This causes issues when navigating away from the summary screen and then navigating back.The solution is simple: we should not store the
export to PDFprinting screen in the menu hierarchy, but the implementation is ugly and I know it. @martinpovolny I'm terribly sorry for this solution and I promise I will fix it in a followup PR.My long term solution would be to split up the
get_global_session_dataandset_global_session_datamethods into smallerbefore_actionmethods and useskip_before_actionin controllers that behave differently from the default one. If you give me the green light, I'll create an issue for this.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649867
@miq-bot add_label bug, gaprindashvili/no
@miq-bot add_reviewer @martinpovolny