-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration - notify backend when quad_truncate
gets changed
#4942
Conversation
(without the cleanup, the diff is: + :javascript
+ miqSelectPickerEvent('quad_truncate', '#{url}'); ) |
I'm always getting complaints that I am creating too big commits 😉 could be this separated into two? |
Thanks @himdel |
without `miqSelectPickerEvent`, any change in `quad_truncate` never gets propagated to the backend => adding `miqSelectPickerEvent` Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650461
made sure that indent of the javascript always matches the indent of the select itself, fixed style issues (double quotes to single quotes, added semicolons), removed useless gettext around field names (not descriptions), and made sure `miqInitSelectPicker` ends up getting called exactly once. https://bugzilla.redhat.com/show_bug.cgi?id=1650461
Rebased and split :) |
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/eaa3dfc2085cb2378a65a6384f6edc706f3cd09f~...8c98e8fdbcee7221d8a3ee45dcc60470b71aba93 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configuration - notify backend when `quad_truncate` gets changed (cherry picked from commit 29734e6) https://bugzilla.redhat.com/show_bug.cgi?id=1650461
Hammer backport details:
|
without
miqSelectPickerEvent
, any change inquad_truncate
never gets propagated to the backend=> adding
miqSelectPickerEvent
introdued in #4034
Also made sure that indent of the javascript always matches the indent of the select itself,
fixed style issues (double quotes to single quotes, added semicolons),
removed useless gettext around field names (not descriptions),
and made sure
miqInitSelectPicker
ends up getting called exactly once.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650461
Cc @skateman