Adds authentication_status to Host.yaml #4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label pending core |
This was referenced Nov 15, 2018
NickLaMuro
changed the title
mzazrivec
reviewed
Nov 20, 2018
This is related to changes in: ManageIQ/manageiq#18196 When `authentication_status` is changed to a `virtual_delegate`, we are able to pre-fetch the values as part of the original query, and avoid an N+1.
NickLaMuro
force-pushed
the
add_authentication_status_to_host_yaml_view
branch
from
749d2f7 to
e652e0d
Compare
|
Checked commit NickLaMuro@e652e0d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on changes in: ManageIQ/manageiq#18196
When
authentication_statusis changed to avirtual_delegate, we are able to pre-fetch the values as part of the original query, and avoid an N+1.Links
Steps for Testing/QA
Testing for this can be see in the
manageiqPR, ManageIQ/manageiq#18196, along with some metrics.