Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EmsCloud.authentication_for_providers to determine topology view status #4897

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Nov 8, 2018

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1502857

Openstack CloudManagers often show up with status 'null' and grey rings on the topology view. This is because the CloudTopologyService chooses the first item from the authentications list, which is frequently an arbitrary keypair instead of the provider credentials. This PR changes CloudTopologyService to use authentication_for_providers like the EmsCloud summary screen, which fixes the problem.

image

@miq-bot
Copy link
Member

miq-bot commented Nov 8, 2018

Checked commit mansam@c10703a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@martinpovolny martinpovolny merged commit c65e752 into ManageIQ:master Nov 13, 2018
@martinpovolny martinpovolny self-assigned this Nov 13, 2018
@martinpovolny martinpovolny added this to the Sprint 99 Ending Nov 19, 2018 milestone Nov 13, 2018
simaishi pushed a commit that referenced this pull request Nov 13, 2018
…topology-status

Use EmsCloud.authentication_for_providers to determine topology view status

(cherry picked from commit c65e752)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1502857
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit e008bd9336db3f3b7d95e39785348e22639b9cdd
Author: Martin Povolny <[email protected]>
Date:   Tue Nov 13 07:58:54 2018 +0100

    Merge pull request #4897 from mansam/use-provider-authentication-for-topology-status
    
    Use EmsCloud.authentication_for_providers to determine topology view status
    
    (cherry picked from commit c65e7523a9d484a1adae9a87e0977298b0951943)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1502857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants