Rescue error messages when executing retire action #4874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit yrudman@8ec0dd5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Depends on: ManageIQ/manageiq#18210 |
yrudman
changed the title
|
@miq-bot add-label blocker |
yrudman
changed the title
|
\cc @h-kataria |
simaishi
pushed a commit
that referenced
this pull request
Nov 19, 2018
…-centralized-administration Rescue error messages when executing retire action (cherry picked from commit 5518e01) https://bugzilla.redhat.com/show_bug.cgi?id=1579017
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 19, 2018
…-centralized-administration Rescue error messages when executing retire action (cherry picked from commit 5518e01) https://bugzilla.redhat.com/show_bug.cgi?id=1648991
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
There is not rescued exception for error raised on backend during execution of retire operation.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1579017
@miq-bot add-label gaprindashvili/yes, hammer/yes, services, bug
BEFORE: there is no any confirmation or error messages when saving new retirement date
AFTER: (if remote server is down)
