Rescue error when canceling job #4855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roliveri
approved these changes
Oct 30, 2018
yrudman
force-pushed
the
rescue-error-when-canceling-job
branch
from
9313acf to
abcecf4
Compare
|
Checked commits yrudman/manageiq-ui-classic@16ff62f~...abcecf4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
looks good. |
simaishi
pushed a commit
that referenced
this pull request
Oct 31, 2018
Rescue error when canceling job (cherry picked from commit bccb10e) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1640704
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 5, 2018
Rescue error when canceling job (cherry picked from commit bccb10e) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1645198
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: not rescued Runtime Error shown in UI when not permitted signal sent to Smart State Analysis state machine.
Bug was introduced in #242
Fix:
rescueerror raised by state machineBefore:
After:
@miq-bot add-label bug, blocker, hammer/yes, gaprindashvili/yes
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1640704
\cc @h-kataria