Turn off 'open_url' if the button is to be displayed for a list

[romanblanco]

Problem is, that if the 'Open URL' is checked, and 'Display for' is changed to anything else than Single, the 'Open URL' checkbox gets disabled and it's not possible to uncheck it.

After these changes, the checkbox is automatically unchecked, if the button is supposed to be displayed for a list.

Also the checkbox will only be visible for a VM and Instance buttons, as it can only be applied there.

Steps for Testing/QA

1. Automation - Automate - Customization - Buttons
2. add a Custom Button to a VM and Instance model

[miq-bot]

Checked commits romanblanco/manageiq-ui-classic@2e41ed2~...cb3e301 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

**

• 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:

warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

[mzazrivec]

This isn't going to work, because content of @resolve[:target_class] will be translated into currently used locale.

You need to use more robust mechanism here, something that doesn't depend on an ad-hoc string.

[romanblanco]

thanks, removed that part

[mzazrivec]

@romanblanco is this hammer/yes ?

[romanblanco]

@mzazrivec hammer/no